Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New cooked meatball sprite + make meatballs cookable #2003

Merged
merged 2 commits into from
Sep 13, 2024
Merged

New cooked meatball sprite + make meatballs cookable #2003

merged 2 commits into from
Sep 13, 2024

Conversation

arimah
Copy link
Contributor

@arimah arimah commented Sep 13, 2024

About the PR

  • New cooked meatball sprite, taken from Goonstation. Actually looks like a cooked meatball!
  • Added a construction graph for cooking meatballs, by heating them to 354 K (80.85 °C). Yum!

Why / Balance

The cooked meatball sprite from upstream doesn't really look like a cooked meatball. It has no real texture and the colours are a bit off. This new sprite, courtesy of Goonstation, actually resembles a meatball!

Additionally, there was no way to actually make a cooked meatball. This PR adds a construction graph that lets you cook raw meatballs by heating, same way you cook steak.

How to test

  1. Spawn or make a raw meatball.
  2. Put the raw meatball in a microwave for 10 seconds or so, or put it on an electric grill.
  3. Marvel at the beautiful, mouthwatering sprite.
  4. Eat and enjoy. (Skip this step if you are vegetarian or vegan.)

Known problems

The sizzle sound doesn't play when you cook the raw meatball. Inherited from upstream; steaks all have the same bug.

Media

2024-09-13.14-47-07.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Negatory.

Changelog
🆑

  • add: Raw meatballs can now be cooked on a grill or in a microwave. Yum!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

RSI Diff Bot; head commit fb58584 merging into 06ce52b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Consumable/Food/meat.rsi

State Old New Status
meatball-cooked Added

Edit: diff updated after fb58584

@Cerebral-Error
Copy link

I am 100% in support of this addition. In fact I would go so far as to say it is vital to the playability of Frontier.

whatston3
whatston3 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, didn't test, would honestly prefer an "# End Frontier" or per-line comment for the construction graph addition in meat.yml:1482.

@arimah
Copy link
Contributor Author

arimah commented Sep 13, 2024

Looks fine, didn't test, would honestly prefer an "# End Frontier" or per-line comment for the construction graph addition in meat.yml:1482.

No problem. I added #End Frontier comments. :D

whatston3
whatston3 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well.

@whatston3 whatston3 merged commit e6215cc into new-frontiers-14:master Sep 13, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Sep 13, 2024
@FrontierATC
Automatic Changelog (#2003)
edae074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatston3 whatston3 whatston3 approved these changes

Assignees
No one assigned
Labels
No C# Sprites YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arimah @Cerebral-Error @whatston3